From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 4 Dec 2018 19:09:22 +0300 From: Vladimir Davydov Subject: Re: [tarantool-patches] Re: [PATCH v5 3/9] box: manage format fields with JSON tree class Message-ID: <20181204160922.m5bse7haiiunyvpf@esperanza> References: <0ff5601b664e42d70d71be658b4ba45fe1237564.1543229303.git.kshcherbatov@tarantool.org> <20181129190757.oyu7kom6drgacd3j@esperanza> <5133fc03-e2ed-0bea-d3d1-47b4b60121e9@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5133fc03-e2ed-0bea-d3d1-47b4b60121e9@tarantool.org> To: Kirill Shcherbatov Cc: tarantool-patches@freelists.org, Kostya Osipov List-ID: On Tue, Dec 04, 2018 at 06:47:16PM +0300, Kirill Shcherbatov wrote: > As we going to work with format fields in a unified way, we > started to use the tree JSON class for working with first-level > format fields. > > Need for #1012 > --- > src/box/sql.c | 16 +++--- > src/box/sql/build.c | 5 +- > src/box/tuple.c | 10 ++-- > src/box/tuple_format.c | 125 +++++++++++++++++++++++++++++------------ > src/box/tuple_format.h | 49 +++++++++++++--- > src/box/vy_stmt.c | 4 +- > 6 files changed, 150 insertions(+), 59 deletions(-) This patch doesn't compile on my laptop. Please fix. In file included from /home/vlad/src/tarantool/src/box/tuple.h:38:0, from /home/vlad/src/tarantool/src/box/tuple_compare.h:38, from /home/vlad/src/tarantool/src/box/tuple_compare.cc:31: /home/vlad/src/tarantool/src/box/tuple_format.h: In function ‘tuple_field* tuple_format_field(tuple_format*, uint32_t)’: /home/vlad/src/tarantool/src/box/tuple_format.h:207:2: sorry, unimplemented: non-trivial designated initializers not supported }; ^ /home/vlad/src/tarantool/src/box/tuple_format.h:207:2: error: missing initializer for member ‘json_token::hash’ [-Werror=missing-field-initializers] /home/vlad/src/tarantool/src/box/tuple_format.h:207:2: error: missing initializer for member ‘json_token::children’ [-Werror=missing-field-initializers] /home/vlad/src/tarantool/src/box/tuple_format.h:207:2: error: missing initializer for member ‘json_token::child_count_max’ [-Werror=missing-field-initializers] /home/vlad/src/tarantool/src/box/tuple_format.h:207:2: error: missing initializer for member ‘json_token::child_count’ [-Werror=missing-field-initializers] /home/vlad/src/tarantool/src/box/tuple_format.h:207:2: error: missing initializer for member ‘json_token::sibling_idx’ [-Werror=missing-field-initializers] /home/vlad/src/tarantool/src/box/tuple_format.h:207:2: error: missing initializer for member ‘json_token::parent’ [-Werror=missing-field-initializers] At global scope: cc1plus: error: unrecognized command line option ‘-Wno-cast-function-type’ [-Werror] cc1plus: error: unrecognized command line option ‘-Wno-format-truncation’ [-Werror] cc1plus: all warnings being treated as errors