From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vdavydov.dev@gmail.com>
Date: Tue, 4 Dec 2018 11:52:14 +0300
From: Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [tarantool-patches] Re: [PATCH 01/11] box: move info_handler
 interface into src/info
Message-ID: <20181204085214.b7ho4tusi3kn6jhf@esperanza>
References: <cover.1543590433.git.v.shpilevoy@tarantool.org>
 <265787a088a3b0625966ee726c16831e5cc877e4.1543590433.git.v.shpilevoy@tarantool.org>
 <20181203204127.GJ2890@chai>
 <8bc2943a-26ed-25b6-9754-cc9da763629b@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8bc2943a-26ed-25b6-9754-cc9da763629b@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@freelists.org, Konstantin Osipov <kostja@tarantool.org>
List-ID: <tarantool-patches.dev.tarantool.org>

On Tue, Dec 04, 2018 at 12:48:25AM +0300, Vladislav Shpilevoy wrote:
> > > +++ b/src/box/lua/info.c
> > > @@ -32,7 +32,7 @@
> > >   #define _GNU_SOURCE
> > >   #endif
> > 
> > Since you are up to cleaning things up a bit, please get rid of
> > file-local _GNU_SOURCE. It should be part of cmake compile flags
> > for this file.
> 
> Unfortunately, Vova required to remove all my cleanup so
> I can not remove _GNU_SOURCE in scope of this patch, sorry.

Don't be ridiculous. Removing a stale definition along the way would be
fine with me. I detested the way you reformatted comments and refactored
the code for no apparent reason. I squashed removal of this pointless
_GNU_SOURCE into your patch before merging it.