From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 3 Dec 2018 23:41:27 +0300 From: Konstantin Osipov Subject: Re: [tarantool-patches] [PATCH 01/11] box: move info_handler interface into src/info Message-ID: <20181203204127.GJ2890@chai> References: <265787a088a3b0625966ee726c16831e5cc877e4.1543590433.git.v.shpilevoy@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <265787a088a3b0625966ee726c16831e5cc877e4.1543590433.git.v.shpilevoy@tarantool.org> To: tarantool-patches@freelists.org Cc: vdavydov.dev@gmail.com List-ID: * Vladislav Shpilevoy [18/11/30 18:41]: > @@ -30,10 +30,10 @@ > */ > #include "box/lua/index.h" > #include "lua/utils.h" > +#include "lua/info.h" > +#include Please prefer local headers whenever you can ("" rather than <>). Your host platform can have a header file info.h at a system-wide location. It's easy if it simply breaks your compile in a funny way. Worse if it doesn't break. > +++ b/src/box/lua/info.c > @@ -32,7 +32,7 @@ > #define _GNU_SOURCE > #endif Since you are up to cleaning things up a bit, please get rid of file-local _GNU_SOURCE. It should be part of cmake compile flags for this file. Otherwise the patch is OK to push. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov