From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vdavydov.dev@gmail.com>
Date: Mon, 3 Dec 2018 11:42:19 +0300
From: Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [PATCH] test: fix http_client.test.lua with curl-7.62
Message-ID: <20181203084219.7b25cw5fsqxojbff@esperanza>
References: <d415e65407f413faa3320be6c63e220e38fa12f8.1543765320.git.alexander.turenko@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <d415e65407f413faa3320be6c63e220e38fa12f8.1543765320.git.alexander.turenko@tarantool.org>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: tarantool-patches@freelists.org
List-ID: <tarantool-patches.dev.tarantool.org>

On Sun, Dec 02, 2018 at 06:52:09PM +0300, Alexander Turenko wrote:
> curl-7.61.1
> 
> ```
> tarantool> require('http.client').new():get('http://localhost:0')
> ---
> - status: 595
>   reason: Couldn't connect to server
> ```
> 
> curl-7.62
> 
> ```
> tarantool> require('http.client').new():get('http://localhost:0')
> ---
> - error: 'curl: URL using bad/illegal format or missing URL'
> ...
> ```
> 
> curl-7.62 returns CURLE_URL_MALFORMAT is case of zero port and tarantool
> raises an error in the case. I think this behaviour is valid, so I fixed
> the test.
> ---
> 
> no issue
> https://github.com/tarantool/tarantool/tree/Totktonada/fix-http-client-test
> 
> The branch is based on 2.1. Please, cherry-pick it also to 1.10.

Pushed to 2.1 and 1.10.