From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vdavydov.dev@gmail.com>
Date: Thu, 29 Nov 2018 20:42:41 +0300
From: Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [tarantool-patches] Re: [PATCH 2/9] wal: remove files needed for
 recovery from backup checkpoints on ENOSPC
Message-ID: <20181129174241.jnxc3yyzl5s5jpxj@esperanza>
References: <cover.1543419109.git.vdavydov.dev@gmail.com>
 <05aea6c7c27c13b6cdf2d7f08f1a0cf85d7a7865.1543419109.git.vdavydov.dev@gmail.com>
 <20181129163103.GB5760@chai>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20181129163103.GB5760@chai>
To: Konstantin Osipov <kostja@tarantool.org>
Cc: tarantool-patches@freelists.org
List-ID: <tarantool-patches.dev.tarantool.org>

On Thu, Nov 29, 2018 at 07:31:03PM +0300, Konstantin Osipov wrote:
> * Vladimir Davydov <vdavydov.dev@gmail.com> [18/11/28 19:16]:
> > Tarantool always keeps box.cfg.checkpoint_count latest checkpoints. It
> > also never deletes WAL files needed for recovery from any of them for
> > the sake of redundancy, even if it gets ENOSPC while trying to write to
> > WAL. This patch changes that behavior: now the WAL thread is allowed to
> > delete backup WAL files in case of emergency ENOSPC - after all it's
> > better than stopping operation.
> 
> If you wish WAL to be part of some of the engine APIs, such as
> checkpointing, you could make it an engine and register in the
> engine list. MySQL does it this way.
> 
> The patch is OK to push.

Pushed to 2.1.