From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 698462FAC3 for ; Thu, 29 Nov 2018 11:31:05 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id E_CmVUP8SyIe for ; Thu, 29 Nov 2018 11:31:05 -0500 (EST) Received: from smtp29.i.mail.ru (smtp29.i.mail.ru [94.100.177.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 23E702FA54 for ; Thu, 29 Nov 2018 11:31:05 -0500 (EST) Received: by smtp29.i.mail.ru with esmtpa (envelope-from ) id 1gSPDT-0006Jf-AL for tarantool-patches@freelists.org; Thu, 29 Nov 2018 19:31:03 +0300 Date: Thu, 29 Nov 2018 19:31:03 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH 2/9] wal: remove files needed for recovery from backup checkpoints on ENOSPC Message-ID: <20181129163103.GB5760@chai> References: <05aea6c7c27c13b6cdf2d7f08f1a0cf85d7a7865.1543419109.git.vdavydov.dev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <05aea6c7c27c13b6cdf2d7f08f1a0cf85d7a7865.1543419109.git.vdavydov.dev@gmail.com> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org * Vladimir Davydov [18/11/28 19:16]: > Tarantool always keeps box.cfg.checkpoint_count latest checkpoints. It > also never deletes WAL files needed for recovery from any of them for > the sake of redundancy, even if it gets ENOSPC while trying to write to > WAL. This patch changes that behavior: now the WAL thread is allowed to > delete backup WAL files in case of emergency ENOSPC - after all it's > better than stopping operation. If you wish WAL to be part of some of the engine APIs, such as checkpointing, you could make it an engine and register in the engine list. MySQL does it this way. The patch is OK to push. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov