From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 3060A305A6 for ; Thu, 29 Nov 2018 11:24:48 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id piE9SvCl0hE1 for ; Thu, 29 Nov 2018 11:24:48 -0500 (EST) Received: from smtp59.i.mail.ru (smtp59.i.mail.ru [217.69.128.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 84EE63057C for ; Thu, 29 Nov 2018 11:24:47 -0500 (EST) Received: by smtp59.i.mail.ru with esmtpa (envelope-from ) id 1gSP7N-00059b-6w for tarantool-patches@freelists.org; Thu, 29 Nov 2018 19:24:45 +0300 Date: Thu, 29 Nov 2018 19:24:45 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH 1/9] wal: separate checkpoint and flush paths Message-ID: <20181129162445.GA32527@chai> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org * Vladimir Davydov [18/11/28 19:16]: > Currently, wal_checkpoint() is used for two purposes. First, to make a > checkpoint (rotate = true). Second, to flush all pending WAL requests > (rotate = false). Since checkpointing has to fail if cascading rollback > is in progress so does flushing. This is confusing. Let's separate the > two paths. I renamed wal_flush() to wal_sync() and pushed the patch. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov