From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 29 Nov 2018 18:39:29 +0300 From: Vladimir Davydov Subject: Re: [tarantool-patches] [PATCH v5 1/9] box: refactor json_path_parser class Message-ID: <20181129153929.zvoui46wmbyt73oa@esperanza> References: <6385c797-c5ee-248f-7103-980a7b2a16df@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6385c797-c5ee-248f-7103-980a7b2a16df@tarantool.org> To: Kirill Shcherbatov Cc: tarantool-patches@freelists.org, Kostya Osipov List-ID: On Mon, Nov 26, 2018 at 03:53:06PM +0300, Kirill Shcherbatov wrote: > Renamed object json_path_node to json_token and > json_path_parser class to json_lexer. Please write more descriptive comments, explaining not just what you're doing, but why. > > Need for #1012 Should be Needed for #1012 I changed the comment to: json: some renames We are planning to link json_path_node objects in a tree and attach some extra information to them so that they could be used to describe a json document structure. Let's rename it to json_token as it sounds more appropriate for the purpose. Also, rename json_path_parser to json_lexer as it isn't a parser, really, it's rather a tokenizer or lexer. Besides, the new name is shorter. Needed for #1012 and pushed the patch to 2.1.