From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 29 Nov 2018 13:51:49 +0300 From: Vladimir Davydov Subject: Re: [tarantool-patches] [PATCH v3 3/7] iproto: remove iproto functions from execute.c Message-ID: <20181129105149.kpxnnjibwvn44zjq@esperanza> References: <987f4ddb6287ce3af8bfbf735e4967c4fadea265.1543344471.git.imeevma@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <987f4ddb6287ce3af8bfbf735e4967c4fadea265.1543344471.git.imeevma@gmail.com> To: imeevma@tarantool.org Cc: v.shpilevoy@tarantool.org, tarantool-patches@freelists.org List-ID: On Tue, Nov 27, 2018 at 10:25:40PM +0300, imeevma@tarantool.org wrote: > To make functions in execute.h more universal we should reduce > their dependence on IPROTO. This patch removes IPROTO functions > from execute.c. > > Needed for #3505 > --- > src/box/execute.c | 48 ++++++++++++++++++++++++++++++------------------ > src/box/execute.h | 13 ++----------- > src/box/iproto.cc | 10 +++++++++- > src/box/xrow.c | 45 --------------------------------------------- > src/box/xrow.h | 19 ------------------- > 5 files changed, 41 insertions(+), 94 deletions(-) Well, this doesn't completely liberate execute.c of iproto dependency - you still use iproto constants, but looking at the following patches I guess it's OK as those iproto constants are used as map keys when formatting output and they will be substituted with strings when the output is formatted as Lua. Pushed to 2.1