From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vdavydov.dev@gmail.com>
Date: Thu, 29 Nov 2018 13:48:30 +0300
From: Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [tarantool-patches] [PATCH v3 2/7] box: add method dump_lua to
 port
Message-ID: <20181129104830.idyjtlmpq2uvojrl@esperanza>
References: <cover.1543344471.git.imeevma@gmail.com>
 <ff2fc3fd58dd99d3a98ad790c8e82363949cb3db.1543344471.git.imeevma@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ff2fc3fd58dd99d3a98ad790c8e82363949cb3db.1543344471.git.imeevma@gmail.com>
To: imeevma@tarantool.org
Cc: tarantool-patches@freelists.org
List-ID: <tarantool-patches.dev.tarantool.org>

On Wed, Nov 28, 2018 at 04:33:49PM +0300, imeevma@tarantool.org wrote:
> New version:
> 
> commit ff2fc3fd58dd99d3a98ad790c8e82363949cb3db
> Author: Mergen Imeev <imeevma@gmail.com>
> Date:   Sat Nov 17 15:37:17 2018 +0300
> 
>     box: add method dump_lua to port
>    
>     New method dump_lua dumps saved in port tuples to Lua stack. It
>     will allow us to call this method without any other interaction
>     with port.
>    
>     Needed for #3505
> 
> diff --git a/src/box/lua/call.c b/src/box/lua/call.c
> index 1f20426..52939ae 100644
> --- a/src/box/lua/call.c
> +++ b/src/box/lua/call.c
> @@ -424,6 +424,7 @@ port_lua_dump_plain(struct port *port, uint32_t *size);
>  static const struct port_vtab port_lua_vtab = {
>      .dump_msgpack = port_lua_dump,
>      .dump_msgpack_16 = port_lua_dump_16,
> +    .dump_lua = NULL,

This should allow us to implement box.call, eventually, which is nice.
Pushed to 2.1.

BTW, please fix your editor you use for editing emails - it seems to
convert tabs to spaces.