From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vdavydov.dev@gmail.com>
Date: Wed, 28 Nov 2018 19:18:12 +0300
From: Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [tarantool-patches] [PATCH] lua: fix tonumber64() for strings
 containing "ULL"
Message-ID: <20181128161812.vqkjxh3roi726zrb@esperanza>
References: <20181120133958.61719-1-sergepetrenko@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20181120133958.61719-1-sergepetrenko@tarantool.org>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: tarantool-patches@freelists.org
List-ID: <tarantool-patches.dev.tarantool.org>

On Tue, Nov 20, 2018 at 04:39:58PM +0300, Serge Petrenko wrote:
> tonumber64() doesn't understand strings with "ULL" like "123ULL". The
> expected output for tonumber64("123ULL") is 123, since 123ULL is a
> correct number notation in lua. However, our function returns null.
> This happens because suffix isn't trimmed in tonumber64.
> 
> Trim ULL/LLU, LL suffixes, but only when no base is specified or
> base is equal to either 2, 10 or 16.

Pushed to 2.1