From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vdavydov.dev@gmail.com>
Date: Tue, 27 Nov 2018 13:01:39 +0300
From: Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [PATCH] sql: fix error handling in sql_analysis_load()
Message-ID: <20181127100139.ugdblemly5sbqq4t@esperanza>
References: <20181122165903.64923-1-sergepetrenko@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20181122165903.64923-1-sergepetrenko@tarantool.org>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: tarantool-patches@freelists.org
List-ID: <tarantool-patches.dev.tarantool.org>

On Thu, Nov 22, 2018 at 07:59:03PM +0300, Serge Petrenko wrote:
> Previously if an error occured in box_index_len() called from
> sql_analysis_load(), the return code (-1 on error) was cast to uint32_t
> and used later as size of memory to be allocated. This lead to assertion
> failures in slab_order() since allocation size was too big. This was
> discovered during investigation of #3779.
> Fix error handling and add some error logging.
> 
> Follow-up #3779

Pushed to 2.1