From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kostja.osipov@gmail.com>
Return-Path: <kostja.osipov@gmail.com>
Date: Mon, 26 Nov 2018 20:41:47 +0300
From: Konstantin Osipov <kostja.osipov@gmail.com>
Subject: Re: [PATCH 2/6] engine: pass vclock instead of lsn to
 collect_garbage callback
Message-ID: <20181126174147.GC7839@chai>
References: <cover.1543152574.git.vdavydov.dev@gmail.com>
 <176d11be84dc464db2467aa34f4b2d42b6e70350.1543152574.git.vdavydov.dev@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <176d11be84dc464db2467aa34f4b2d42b6e70350.1543152574.git.vdavydov.dev@gmail.com>
To: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: tarantool-patches@freelists.org
List-ID: <tarantool-patches.dev.tarantool.org>

* Vladimir Davydov <vdavydov.dev@gmail.com> [18/11/26 10:27]:
> First, this is consistent with other engine callbacks, such as
> checkpoint or backup.
> 
> Second, a vclock can be used as a search key in a vclock set,
> which in turn can make code more straightforward, e.g. look how
> this patch simplifies vy_log_prev_checkpoint().

OK to push.


-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov