From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 71F252F6E6 for ; Fri, 23 Nov 2018 00:51:36 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id u7eyAXkyB7rg for ; Fri, 23 Nov 2018 00:51:36 -0500 (EST) Received: from smtp55.i.mail.ru (smtp55.i.mail.ru [217.69.128.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id A6FFC2F6AC for ; Fri, 23 Nov 2018 00:51:35 -0500 (EST) Date: Fri, 23 Nov 2018 08:51:29 +0300 From: Kirill Yukhin Subject: [tarantool-patches] Re: [PATCH] sql: fix row count calculation for DELETE optimization Message-ID: <20181123055129.c4lxqqqsuoocha7h@tarantool.org> References: <20181119121256.8154-1-korablev@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20181119121256.8154-1-korablev@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: v.shpilevoy@tarantool.org, Nikita Pettik Hello, On 19 Nov 15:12, Nikita Pettik wrote: > When SQL DELETE statement comes in most primitive from without WHERE > clause and foreign key constraints, it is optimized and processed with > one VDBE instruction (instead of several OP_Delete). However, it was > forgotten to account affected tuples by row counter. Current patch fixes > this obvious defect. > > Closes #3816 > --- > Branch: https://github.com/tarantool/tarantool/tree/np/gh-3816-account-changes-for-simple-delete > Issue: https://github.com/tarantool/tarantool/issues/3816 I've pushed the patch into 2.1 branch. -- Regards, Kirill Yukhin