From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 19 Nov 2018 11:20:58 +0300 From: Vladimir Davydov Subject: Re: [PATCH] vinyl: do not apply run_count_per_level to the last level Message-ID: <20181119082058.pmgqoo5mgyxtzojy@esperanza> References: <6dd0d2fb7e0eff306f141fc867fa5b1b3e4fa3b1.1542387257.git.vdavydov.dev@gmail.com> <20181118163752.GC19841@chai> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181118163752.GC19841@chai> To: Konstantin Osipov Cc: tarantool-patches@freelists.org List-ID: On Sun, Nov 18, 2018 at 07:37:52PM +0300, Konstantin Osipov wrote: > * Vladimir Davydov [18/11/17 07:05]: > > Currently, run_count_per_level index option is applied to each LSM tree > > level. As a result, we may end up storing each key run_count_per_level > > times at the last level alone, which would result in prohibitive space > > amplification. To avoid that, let's ignore run_count_per_level for the > > last level. > > > > Note, we have to tweak quite a few vinyl tests, because they implicitly > > relied on the fact that producing run_count_per_level dumps would never > > trigger compaction. > > OK to push. Pushed to 1.10.