From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Sun, 18 Nov 2018 19:37:52 +0300 From: Konstantin Osipov Subject: Re: [PATCH] vinyl: do not apply run_count_per_level to the last level Message-ID: <20181118163752.GC19841@chai> References: <6dd0d2fb7e0eff306f141fc867fa5b1b3e4fa3b1.1542387257.git.vdavydov.dev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6dd0d2fb7e0eff306f141fc867fa5b1b3e4fa3b1.1542387257.git.vdavydov.dev@gmail.com> To: Vladimir Davydov Cc: tarantool-patches@freelists.org List-ID: * Vladimir Davydov [18/11/17 07:05]: > Currently, run_count_per_level index option is applied to each LSM tree > level. As a result, we may end up storing each key run_count_per_level > times at the last level alone, which would result in prohibitive space > amplification. To avoid that, let's ignore run_count_per_level for the > last level. > > Note, we have to tweak quite a few vinyl tests, because they implicitly > relied on the fact that producing run_count_per_level dumps would never > trigger compaction. OK to push. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov