From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 15 Nov 2018 14:25:16 +0300 From: Vladimir Davydov Subject: Re: [tarantool-patches] [PATCH v2 1/1] box: restore region after box.snapshot() Message-ID: <20181115112516.xgu2bcqxaoeaqynv@esperanza> References: <90fd04c36016067157b95cf689eb8780daf79e96.1542192128.git.imeevma@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <90fd04c36016067157b95cf689eb8780daf79e96.1542192128.git.imeevma@gmail.com> To: imeevma@tarantool.org Cc: tarantool-patches@freelists.org, v.shpilevoy@tarantool.org List-ID: On Wed, Nov 14, 2018 at 01:44:29PM +0300, imeevma@tarantool.org wrote: > Before this patch region wasn't restored after box.snapshot() so > some tests fail due to "memory leak". This patch adds additional > memory management and fixes mentioned failures. Bad comment. It's unclear what this patch actually does to fix the issue. Looks like you didn't bother to rewrite it in v2. I fixed it and pushed the patch to 2.1 > > Closes #3732 > --- > Issue: https://github.com/tarantool/tarantool/issues/assigned/ImeevMA Invalid link. BTW, "Issue:" and "Branch:" are usless. Also, changelog since v2 is missing. And it would be prudent to put a link here to v1, like this: Changes in v2: - Use malloc() in memtx instead of region_alloc(). - Truncate region in engine callbacks rather than in box_snapshot(). v1: https://www.freelists.org/post/tarantool-patches/PATCH-v1-11-box-restore-region-after-boxsnapshot > Branch: https://github.com/tarantool/tarantool/tree/imeevma/gh-3732-additional-memory-managament-in-box_snapshot > > src/box/memtx_engine.c | 41 ++++++++++++++++++++--------------------- > src/box/vy_log.c | 11 ++++++++--- > test/engine/snapshot.result | 35 +++++++++++++++++++++++++++++++++++ > test/engine/snapshot.test.lua | 17 +++++++++++++++++ > 4 files changed, 80 insertions(+), 24 deletions(-)