From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 394B42D1C7 for ; Wed, 14 Nov 2018 12:41:09 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6H8MNwZbvAGt for ; Wed, 14 Nov 2018 12:41:09 -0500 (EST) Received: from smtp47.i.mail.ru (smtp47.i.mail.ru [94.100.177.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 804D82D1A9 for ; Wed, 14 Nov 2018 12:41:08 -0500 (EST) Date: Wed, 14 Nov 2018 20:41:07 +0300 From: Alexander Turenko Subject: [tarantool-patches] Re: [PATCH 2/2] sql: remove GLOB from Tarantool Message-ID: <20181114174106.nvdjpixk57cd4aq3@tkn_work_nb> References: <3f8354cb-4a47-c3de-164b-c776c792b991@tarantool.org> <090683CD-6F88-492D-AF48-631220A24E36@tarantool.org> <20181021034805.alwhmkpz3fbopqjz@tkn_work_nb> <20181029121529.2d6ccnh5qayiz7ld@tkn_work_nb> <6F5AC823-3016-4918-A588-6BB6B621B777@tarantool.org> <20181109121828.mjdoouycwvonimms@tkn_work_nb> <34EFA3FE-95C1-49FC-9668-11DDD93EC42D@tarantool.org> <20181113192305.v3uxbrp6ebqrb4gs@tkn_work_nb> <086379A5-15D0-4D16-951E-5F5DBE852068@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <086379A5-15D0-4D16-951E-5F5DBE852068@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: "n.pettik" Cc: tarantool-patches@freelists.org, Nikita Tatunov On Wed, Nov 14, 2018 at 05:16:52PM +0300, n.pettik wrote: > > > > On 13 Nov 2018, at 22:23, Alexander Turenko wrote: > > > > Hi! > > > > I gave some minor comments and I think I cannot add any value anymore. > > Nikita N., can you look into this patch? > > > Part of #3589 > > Part of #3572 > > Needed for #3251 > > Needed for #3334 > > Why this patch is ’needed for’ but comes after > these issues are closed by previous patch? > > Also I don’t like the fact that your patch not only removes > GLOB function, but also changes some user-visible interface. > It still would be OK if you wrote about it in commit message > or in doc request. For instance, as I understand from code, > percent symbol (‘%’) now works as star (‘*’) did before. > '*' from GLOB is subject to remove, '%' from LIKE still doing its work. Comments that use names of symbols from GLOB are changed to use LIKE syntax. > Personally I don’t like many code style fixes because > they obfuscate patch and make it complicate to review. > What is more, they don’t deal with all problems: they > partially fix comments but don’t fix naming. It looks awful. > But since it is done and two reviewers already gave their > OK I guess it would be irrational to start from scratch. > Agreed. We should push developers to do refactoring in a separate commit underneath actual changes. > Finally, to be honest I didn’t review ALL changed tests. > I looked through and they seem to be OK. > > I’ve pushed also several non-functional fixes - > see branch np/gh-3251-where-like-hangs. > Don't have objections against your changes. > Let's assume this as formal LGTM.