From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 843892F21D for ; Thu, 1 Nov 2018 10:55:37 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BFLcmaHHo6IE for ; Thu, 1 Nov 2018 10:55:37 -0400 (EDT) Received: from smtp5.mail.ru (smtp5.mail.ru [94.100.179.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 3EF9D2F21A for ; Thu, 1 Nov 2018 10:55:37 -0400 (EDT) Date: Thu, 1 Nov 2018 17:55:34 +0300 From: Kirill Yukhin Subject: [tarantool-patches] Re: [PATCH] sql: make DROP TABLE delete entry from _sequence_data Message-ID: <20181101145534.jejrl72k5rkjhhe5@tarantool.org> References: <20181015183615.28548-1-korablev@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: Nikita Pettik Hello, On 15 Oct 21:54, Vladislav Shpilevoy wrote: > Hi! Thanks for the patch! > > > diff --git a/test/sql/drop-table.result b/test/sql/drop-table.result > > index 08f249668..bf02e3def 100644 > > --- a/test/sql/drop-table.result > > +++ b/test/sql/drop-table.result > > @@ -29,6 +29,23 @@ box.sql.execute("INSERT INTO zzzoobar VALUES (111, 222, 'c3', 444)") > > --- > > - error: 'no such table: ZZZOOBAR' > > ... > > +-- gh-3712: if space features sequence, data from _sequence_data > > +-- must be deleted before space is dropped. > > +-- > > +box.sql.execute("CREATE TABLE t1 (id INT PRIMARY KEY AUTOINCREMENT);") > > +--- > > +... > > +box.sql.execute("INSERT INTO t1 VALUES (NULL);") > > +--- > > +... > > +box.snapshot() > > +--- > > +- ok > > +... > > +test_run:cmd('restart server default') > > Unfortunately, we have no luxury of time to restart a > server on such a simple test. Lets just check that > _sequence_data space is empty. > > > +box.sql.execute("DROP TABLE t1;") > > +--- > > +... > > -- Cleanup > > -- DROP TABLE should do the job > > -- Debug > I've missed start of the thread. Anyway, I've pushed the patch into 2.1 branch. -- Regards, Kirill Yukhin