From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 1 Nov 2018 17:38:41 +0300 From: Konstantin Osipov Subject: Re: [tarantool-patches] [PATCH v5 04/12] box: introduce tuple_format_add_key_part Message-ID: <20181101143841.GF30032@chai> References: <117feb46f029d4ba5d142fc614e063e2796a4f38.1540795996.git.kshcherbatov@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <117feb46f029d4ba5d142fc614e063e2796a4f38.1540795996.git.kshcherbatov@tarantool.org> To: tarantool-patches@freelists.org Cc: vdavydov.dev@gmail.com, Kirill Shcherbatov List-ID: * Kirill Shcherbatov [18/10/29 20:25]: > Introduced a new tuple_format_add_key_part that makes format > initialization for specified key_part and configuration. > This decrease tuple_format_create routine complexity and would > be used to initialize structures in format for JSON path. The patch is OK to push but I object to the name. A format doesn't contain key parts. A key def contains key part. A format is consistent with key parts. tuple_format_update_with_key_part() perhaps? tuple_format_combine_with_key_part()? tuple_format_mix_in_key_part()? tuple_format_use_key_part()? -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov