From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 7072A2D7BF for ; Thu, 1 Nov 2018 08:21:57 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hUKmN0KVq3LO for ; Thu, 1 Nov 2018 08:21:57 -0400 (EDT) Received: from smtp37.i.mail.ru (smtp37.i.mail.ru [94.100.177.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 273CA2D78F for ; Thu, 1 Nov 2018 08:21:57 -0400 (EDT) Date: Thu, 1 Nov 2018 15:21:53 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH v7 1/2] sql: return all generated ids via IPROTO Message-ID: <20181101122153.GA30032@chai> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: korablev@tarantool.org, v.shpilevoy@tarantool.org * imeevma@tarantool.org [18/10/29 20:25]: > According to documentation some JDBC functions have an ability to > return all ids that were generated in executed INSERT statement. > This patch gives a way to implement such functionality. Very nice. The trick with fiber_gc() is also good IMHO. Thank you for working on this! We're going to do a lot of integration of box and vdbe - triggers, constraints, etc, so I think this patch is on track from architecture point of view as well, we will need to access vdbe from box increasingly more as we progress along with the integration. > Closes #261 -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov