From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 9D1712DC09
	for <tarantool-patches@freelists.org>; Thu,  1 Nov 2018 06:30:52 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id FCi-mbuyse7l for <tarantool-patches@freelists.org>;
	Thu,  1 Nov 2018 06:30:52 -0400 (EDT)
Received: from smtp29.i.mail.ru (smtp29.i.mail.ru [94.100.177.89])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id DB89F2D84B
	for <tarantool-patches@freelists.org>; Thu,  1 Nov 2018 06:30:51 -0400 (EDT)
Date: Thu, 1 Nov 2018 13:30:45 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH 1/2] sql: LIKE & GLOB pattern
 comparison issue
Message-ID: <20181101103045.fmhy3y6l342wojd6@tkn_work_nb>
References: <87897608-173E-45EB-80A1-8B249706D8A1@tarantool.org>
 <6a1352e9-425c-d656-1bec-bb04d9f0fee6@tarantool.org>
 <58B407E2-AF5D-4531-A9FF-9DC57CE0070B@tarantool.org>
 <860a125b-19f3-3bf1-8705-25156ff508ab@tarantool.org>
 <45338A27-C589-4330-B206-A4E379A4DE75@tarantool.org>
 <BE06C955-2ED3-42D7-87B8-93F138448E3D@tarantool.org>
 <20181021035140.avx6d3rokx5ta6hi@tkn_work_nb>
 <6740948F-6C40-4C0F-B237-7C3573225FBC@tarantool.org>
 <20181029130123.f254chdxxuwi6c4w@tkn_work_nb>
 <3D4337BA-F528-425C-B352-C195C20DA282@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <3D4337BA-F528-425C-B352-C195C20DA282@tarantool.org>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: Nikita Tatunov <n.tatunov@tarantool.org>
Cc: korablev@tarantool.org, tarantool-patches@freelists.org

On Wed, Oct 31, 2018 at 08:25:12AM +0300, Nikita Tatunov wrote:
> 
> 
> > On Oct 29, 2018, at 16:01, Alexander Turenko <alexander.turenko@tarantool.org> wrote:
> > 
> > The patch is okay except one note re test case.
> > 
> > WBR, Alexander Turenko.
> > 
> >> --- EVIDENCE-OF: R-39414-35489 The infix GLOB operator is implemented by
> >> --- calling the function glob(Y,X) and can be modified by overriding that
> >> --- function.
> > 
> > This test case was removed, while we have not a similar one for LIKE.
> 
> I guess it is concerned more with the second patch.
> Anyways. If you mean the tests following this comment then
> actually there are some similar tests for LIKE (15.1.x).

Found test cases with user-defined like function. Missed it before,
sorry.

I have no more comments re this commit. Please, proceed with Nikita.

WBR, Alexander Turenko.