From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 24 Oct 2018 20:13:17 +0300 From: Konstantin Osipov Subject: Re: [PATCH v3 4/5] wal: add event_mask to wal_watcher Message-ID: <20181024171317.GJ12973@chai> References: <9cae1b27408a1ffc94ee3fd884bad2633e90e7c3.1540388352.git.vdavydov.dev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9cae1b27408a1ffc94ee3fd884bad2633e90e7c3.1540388352.git.vdavydov.dev@gmail.com> To: Vladimir Davydov Cc: tarantool-patches@freelists.org List-ID: * Vladimir Davydov [18/10/24 16:43]: > In order to implement WAL auto-deletion, we need a notification channel > through which the WAL thread could notify TX that a WAL file was deleted > so that the latter can shoot off stale replicas. We will reuse existing > wal_watcher API for this. Currently, wal_watcher invokes the registered > callback on each WAL write so using it as is would be inefficient. To > avoid that, let's allow the caller to specify events of interest when > registering a wal_watcher. The approach with pending events is of course better than dispatching within the callback, but it seems you're re-inventing cbus. Let's discuss f2f and agree on a solution rather than you waste time on trying to address the remarks of a stubborn reviewer. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov