From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vdavydov.dev@gmail.com>
Date: Wed, 24 Oct 2018 14:19:58 +0300
From: Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [tarantool-patches] Re: [PATCH 2/3] vinyl: account disk
 statements of each type
Message-ID: <20181024111958.dpgxnxteqiefehnd@esperanza>
References: <cover.1540057300.git.vdavydov.dev@gmail.com>
 <1557795f8e2300a4f6d798003c67ce5bce43f6f6.1540057300.git.vdavydov.dev@gmail.com>
 <20181023085845.GB17670@chai>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20181023085845.GB17670@chai>
To: Konstantin Osipov <kostja@tarantool.org>
Cc: tarantool-patches@freelists.org
List-ID: <tarantool-patches.dev.tarantool.org>

On Tue, Oct 23, 2018 at 11:58:45AM +0300, Konstantin Osipov wrote:
> * Vladimir Davydov <vdavydov.dev@gmail.com> [18/10/20 23:19]:
> > This patch adds a new entry to per index statistics reported by
> > index.stat():
> > 
> >   disk.statement
> >     inserts
> >     replaces
> >     deletes
> >     upserts
> > 
> > It shows the number of statements of each type stored in run files.
> > The new statistics are persisted in index files. We will need this
> > information so that we can force major compaction when there are too
> > many DELETE statements accumulated in run files.
> > 
> > Needed for #3225
> 
> Please add a documentation request to the changeset comment and
> ensure there is a doc ticket - docbot had uptime issues recently.
> 
> Moreover, it turned out a number of features were not filed for
> documentation in 1.10 release, I believe we need to ban external
> behaviour changes in "internal" patches - any patch which changes
> the server api should be assigned to an own ticket.
> 
> The patch itself is OK to push. 

Pushed to 1.10-features and opened a doc ticket:

https://github.com/tarantool/doc/issues/645