From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 64E4E2B96E for ; Tue, 23 Oct 2018 04:58:44 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gklotwUfGFqq for ; Tue, 23 Oct 2018 04:58:44 -0400 (EDT) Received: from smtp56.i.mail.ru (smtp56.i.mail.ru [217.69.128.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 257222B29D for ; Tue, 23 Oct 2018 04:58:44 -0400 (EDT) Received: by smtp56.i.mail.ru with esmtpa (envelope-from ) id 1gEsWT-0005qZ-R7 for tarantool-patches@freelists.org; Tue, 23 Oct 2018 11:58:46 +0300 Date: Tue, 23 Oct 2018 11:58:45 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH 2/3] vinyl: account disk statements of each type Message-ID: <20181023085845.GB17670@chai> References: <1557795f8e2300a4f6d798003c67ce5bce43f6f6.1540057300.git.vdavydov.dev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1557795f8e2300a4f6d798003c67ce5bce43f6f6.1540057300.git.vdavydov.dev@gmail.com> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org * Vladimir Davydov [18/10/20 23:19]: > This patch adds a new entry to per index statistics reported by > index.stat(): > > disk.statement > inserts > replaces > deletes > upserts > > It shows the number of statements of each type stored in run files. > The new statistics are persisted in index files. We will need this > information so that we can force major compaction when there are too > many DELETE statements accumulated in run files. > > Needed for #3225 Please add a documentation request to the changeset comment and ensure there is a doc ticket - docbot had uptime issues recently. Moreover, it turned out a number of features were not filed for documentation in 1.10 release, I believe we need to ban external behaviour changes in "internal" patches - any patch which changes the server api should be assigned to an own ticket. The patch itself is OK to push. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov