From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 74C362D009 for ; Tue, 23 Oct 2018 03:42:13 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id R7wIrkWAoZHJ for ; Tue, 23 Oct 2018 03:42:13 -0400 (EDT) Received: from smtp34.i.mail.ru (smtp34.i.mail.ru [94.100.177.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 344A52D007 for ; Tue, 23 Oct 2018 03:42:13 -0400 (EDT) Received: by smtp34.i.mail.ru with esmtpa (envelope-from ) id 1gErKN-00046X-Dr for tarantool-patches@freelists.org; Tue, 23 Oct 2018 10:42:11 +0300 Date: Tue, 23 Oct 2018 10:42:11 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH 8/8] tuple: zap tuple_extra Message-ID: <20181023074211.GI9849@chai> References: <137ff9cb723921ebcaa4af3455b2466866f17047.1539539421.git.vdavydov.dev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <137ff9cb723921ebcaa4af3455b2466866f17047.1539539421.git.vdavydov.dev@gmail.com> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org * Vladimir Davydov [18/10/15 10:15]: > Actually, the whole idea of tuple_extra() is rather crooked: why > would we need it if we can inherit struct tuple instead, as we do > in case of memtx_tuple and vy_stmt? Accessing an inherited struct > is much more convenient than using tuple_extra(). Because you don't want to inherit a tuple to store last access time, or some information specific to functional index or row id. That was the idea at least. This patch and the entire patch set is OK to push, when we get to implementing the above mentioned features we can consider putting it back in again. > > So this patch gets rid of tuple_extra(). To do that, it partially > reverts the following commits: -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov