From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 3674D2474E for ; Thu, 18 Oct 2018 14:15:50 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mT1qOOpI-3Fo for ; Thu, 18 Oct 2018 14:15:50 -0400 (EDT) Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id EA0C4246D4 for ; Thu, 18 Oct 2018 14:15:49 -0400 (EDT) Date: Thu, 18 Oct 2018 21:15:48 +0300 From: Alexander Turenko Subject: [tarantool-patches] Re: [PATCH] box: add tuple:size function Message-ID: <20181018181548.hxzrckuwsioqm3nf@tkn_work_nb> References: <1538070923-23087-1-git-send-email-ivushkinalex@gmail.com> <20181016182144.GB5454@chai> <20181017072810.bxyfdrtq2rsxj5ub@tkn_work_nb> <20181017152949.GB19013@chai> <20181017155034.ycixq6j27vkoltzx@tkn_work_nb> <20181018181131.GA16740@chai> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20181018181131.GA16740@chai> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: Konstantin Osipov Cc: tarantool-patches@freelists.org, Morgan-iv On Thu, Oct 18, 2018 at 09:11:31PM +0300, Konstantin Osipov wrote: > * Alexander Turenko [18/10/17 18:53]: > > On Wed, Oct 17, 2018 at 06:29:49PM +0300, Konstantin Osipov wrote: > > > * Alexander Turenko [18/10/17 10:45]: > > > > Are tuple.bsize and box_tuple_bsize() subjects to change or it is only > > > > about the Lua part? > > > > > > tuple.bsize is used internally, so I don't think you should change > > > it. But it's better to rename it to msgpack_size or something like > > > that to avoid ambiguity. > > > > > > box_tuple_bsize() should be ok to change. > > > > > > > So should I use tuple.bsize in my current WIP patch (merger) and don't > > use box_tuple_bsize() and things will not become broken in the future? > > No, I suggested to rename tuple.bsize to tuple.msgpack-size. > Direct access to struct tuple members from modules should be > prohibited. > It was about the build-in module. > > BTW, I wonder why such simple public accessor function as > > box_tuple_bsize() is not defined in the header file to allow inlining? > > Since it's part of the plugin api I guess. > Thanks, got it. > -- > Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 > http://tarantool.io - www.twitter.com/kostja_osipov >