From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id E95F02BADF for ; Wed, 17 Oct 2018 11:50:37 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DI9gR1g_yaO1 for ; Wed, 17 Oct 2018 11:50:37 -0400 (EDT) Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id AA1502BAB9 for ; Wed, 17 Oct 2018 11:50:37 -0400 (EDT) Date: Wed, 17 Oct 2018 18:50:34 +0300 From: Alexander Turenko Subject: [tarantool-patches] Re: [PATCH] box: add tuple:size function Message-ID: <20181017155034.ycixq6j27vkoltzx@tkn_work_nb> References: <1538070923-23087-1-git-send-email-ivushkinalex@gmail.com> <20181016182144.GB5454@chai> <20181017072810.bxyfdrtq2rsxj5ub@tkn_work_nb> <20181017152949.GB19013@chai> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20181017152949.GB19013@chai> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: Konstantin Osipov Cc: tarantool-patches@freelists.org, Morgan-iv On Wed, Oct 17, 2018 at 06:29:49PM +0300, Konstantin Osipov wrote: > * Alexander Turenko [18/10/17 10:45]: > > Are tuple.bsize and box_tuple_bsize() subjects to change or it is only > > about the Lua part? > > tuple.bsize is used internally, so I don't think you should change > it. But it's better to rename it to msgpack_size or something like > that to avoid ambiguity. > > box_tuple_bsize() should be ok to change. > So should I use tuple.bsize in my current WIP patch (merger) and don't use box_tuple_bsize() and things will not become broken in the future? BTW, I wonder why such simple public accessor function as box_tuple_bsize() is not defined in the header file to allow inlining? WBR, Alexander Turenko. > > -- > Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 > http://tarantool.io - www.twitter.com/kostja_osipov