From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 130A02BBB8 for ; Wed, 17 Oct 2018 03:28:13 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aE4M-KZMypxR for ; Wed, 17 Oct 2018 03:28:12 -0400 (EDT) Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id BE6812A7BA for ; Wed, 17 Oct 2018 03:28:12 -0400 (EDT) Date: Wed, 17 Oct 2018 10:28:10 +0300 From: Alexander Turenko Subject: [tarantool-patches] Re: [PATCH] box: add tuple:size function Message-ID: <20181017072810.bxyfdrtq2rsxj5ub@tkn_work_nb> References: <1538070923-23087-1-git-send-email-ivushkinalex@gmail.com> <20181016182144.GB5454@chai> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20181016182144.GB5454@chai> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: Konstantin Osipov Cc: tarantool-patches@freelists.org, Morgan-iv On Tue, Oct 16, 2018 at 09:21:44PM +0300, Konstantin Osipov wrote: > * AlexeyIvushkin [18/09/27 20:57]: > > From: Morgan-iv > > > > When operating with tuples, we only have tuple:bsize function > > to get size of tuple. tuple:bsize returns only size of MessagePack > > part of struct tuple, without tuple_meta. New function tuple:size > > returns size of all tuple, with MessagePack and tuple_meta > > > > Closes #2256 > > The bug should be fixed as described by Roman. > > tuple:bsize() behaviour should be changed to be more accurate, > i.e. return entire binary footprint of a tuple. > > No need to introduce a new function. > > I don't think it's a "true" incompatible change, the purpose of > bsize() has always been to inform the user about the binary > footprint, so we're simply fixing a bug in the implementation. > Are tuple.bsize and box_tuple_bsize() subjects to change or it is only about the Lua part? > -- > Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 > http://tarantool.io - www.twitter.com/kostja_osipov >