From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 18B4D2C857 for ; Tue, 16 Oct 2018 15:08:00 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sotuYEgcX3C6 for ; Tue, 16 Oct 2018 15:08:00 -0400 (EDT) Received: from smtp40.i.mail.ru (smtp40.i.mail.ru [94.100.177.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id CB2A82C817 for ; Tue, 16 Oct 2018 15:07:59 -0400 (EDT) Received: from [185.6.245.178] (port=48652 helo=atlas.local) by smtp40.i.mail.ru with esmtpa (envelope-from ) id 1gCUhC-0000dy-8X for tarantool-patches@freelists.org; Tue, 16 Oct 2018 22:07:58 +0300 Date: Tue, 16 Oct 2018 22:07:57 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH 1/5] xlog: fix filename in error messages Message-ID: <20181016190757.GI5454@chai> References: <3273817f5cb79af421a33b08a1539eb27a8ab9d2.1538942600.git.vdavydov.dev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3273817f5cb79af421a33b08a1539eb27a8ab9d2.1538942600.git.vdavydov.dev@gmail.com> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org * Vladimir Davydov [18/10/08 13:52]: > - xlog_rename() doesn't strip xlog->filename of inprogress suffix so > write errors will mistakenly report the filename as inprogress. > - xlog_create() uses a name without inprogress suffix for error > reporting while it actually creates an inprogress file. This fragment is trivial and is OK to push. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov