From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 13C8D2BD1E for ; Tue, 16 Oct 2018 14:25:21 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3sqDpWr734ua for ; Tue, 16 Oct 2018 14:25:21 -0400 (EDT) Received: from smtp60.i.mail.ru (smtp60.i.mail.ru [217.69.128.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id C8CDA1FFF5 for ; Tue, 16 Oct 2018 14:25:20 -0400 (EDT) Received: from [185.6.245.178] (port=47846 helo=atlas.local) by smtp60.i.mail.ru with esmtpa (envelope-from ) id 1gCU1v-0005LE-3E for tarantool-patches@freelists.org; Tue, 16 Oct 2018 21:25:19 +0300 Date: Tue, 16 Oct 2018 21:25:18 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH v2 09/11] vinyl: do not account zero dump bandwidth Message-ID: <20181016182518.GC5454@chai> References: <13fecfb17369a9d4819eb82115722c37245b2db0.1538155645.git.vdavydov.dev@gmail.com> <20181012132721.vbshvexo2igrhtur@esperanza> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181012132721.vbshvexo2igrhtur@esperanza> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org * Vladimir Davydov [18/10/12 21:23]: > Turns out this isn't enough. We'd better not account too small dumps, > because such dumps have too high overhead associated with file creation. > Our tests create a lot of small dumps using box.snapshot(). Taking them > into account may slow down the overall test execution time or even break > some tests. Let's ignore all dumps of size less than 1 MB for bandwidth > estimation. The new patch is below. Let's talk face to face, but this entire clutch seems to be becoming too huge with this patch. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov