From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 7E5962C6CB for ; Tue, 16 Oct 2018 14:21:49 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6sodjSCXeV9k for ; Tue, 16 Oct 2018 14:21:49 -0400 (EDT) Received: from smtp35.i.mail.ru (smtp35.i.mail.ru [94.100.177.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 3F2F82C6BE for ; Tue, 16 Oct 2018 14:21:49 -0400 (EDT) Date: Tue, 16 Oct 2018 21:21:44 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH] box: add tuple:size function Message-ID: <20181016182144.GB5454@chai> References: <1538070923-23087-1-git-send-email-ivushkinalex@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1538070923-23087-1-git-send-email-ivushkinalex@gmail.com> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: Morgan-iv * AlexeyIvushkin [18/09/27 20:57]: > From: Morgan-iv > > When operating with tuples, we only have tuple:bsize function > to get size of tuple. tuple:bsize returns only size of MessagePack > part of struct tuple, without tuple_meta. New function tuple:size > returns size of all tuple, with MessagePack and tuple_meta > > Closes #2256 The bug should be fixed as described by Roman. tuple:bsize() behaviour should be changed to be more accurate, i.e. return entire binary footprint of a tuple. No need to introduce a new function. I don't think it's a "true" incompatible change, the purpose of bsize() has always been to inform the user about the binary footprint, so we're simply fixing a bug in the implementation. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov