From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 6B1C72992A
	for <tarantool-patches@freelists.org>; Wed, 10 Oct 2018 09:40:16 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id mXTq8QPbVgGS for <tarantool-patches@freelists.org>;
	Wed, 10 Oct 2018 09:40:16 -0400 (EDT)
Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id C65612658B
	for <tarantool-patches@freelists.org>; Wed, 10 Oct 2018 09:40:15 -0400 (EDT)
Date: Wed, 10 Oct 2018 16:40:12 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH] jdbc: fix primary keys meta retrieval
Message-ID: <20181010134012.hauovwejvcoltffn@tkn_work_nb>
References: <1537954408-3275-1-git-send-email-ztarvos@gmail.com>
 <20181001130427.zlugbqlg3madlo7r@tkn_work_nb>
 <20181009092158.GA17512@daedra.localdomain>
 <20181009154005.uj5cwb6hcmhsmbju@tkn_work_nb>
 <20181010081401.GA22345@daedra.localdomain>
 <20181010101938.7vtr3rw632hw2vyw@tkn_work_nb>
 <20181010110947.GA6883@daedra.localdomain>
 <20181010125020.4i6mizyxz6ftc2m7@tkn_work_nb>
 <20181010131907.GA18776@daedra.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20181010131907.GA18776@daedra.localdomain>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: Sergei Kalashnikov <ztarvos@gmail.com>
Cc: tarantool-patches <tarantool-patches@freelists.org>

Thanks!

I have checked in the patch into connector-1.8.jdbc branch.

WBR, Alexander Turenko.

On Wed, Oct 10, 2018 at 04:19:09PM +0300, Sergei Kalashnikov wrote:
> No problem. I pushed the amended commit to the branch.
> 
> Thank you.
> 
> On Wed, Oct 10, 2018 at 03:50:20PM +0300, Alexander Turenko wrote:
> > On Wed, Oct 10, 2018 at 02:09:48PM +0300, Sergei Kalashnikov wrote:
> > > Sure. Please find the amended patch at the very end of this mail.
> > > 
> > 
> > Found one more such case. Sorry, missed that before.
> > 
> > diff --git a/src/test/java/org/tarantool/jdbc/JdbcExceptionHandlingTest.java b/src/test/java/org/tarantool/jdbc/JdbcExceptionHandlingTest.java
> > index 39d6326..8cc7acc 100644
> > --- a/src/test/java/org/tarantool/jdbc/JdbcExceptionHandlingTest.java
> > +++ b/src/test/java/org/tarantool/jdbc/JdbcExceptionHandlingTest.java
> > @@ -25,10 +25,10 @@ public class JdbcExceptionHandlingTest {
> >      /**
> >       * Simulates meta parsing error: missing "name" field in a space format for the primary key.
> >       *
> > -     * @throws Exception on failure.
> > +     * @throws SQLException on failure.
> >       */
> >      @Test
> > -    public void testDatabaseMetaDataGetPrimaryKeysFormatError() throws Exception {
> > +    public void testDatabaseMetaDataGetPrimaryKeysFormatError() throws SQLException {
> >          TarantoolConnection tntCon = mock(TarantoolConnection.class);
> >          SQLConnection conn = new SQLConnection(tntCon, "", new Properties());
> > 
> > You can don't attach the whole patch in case of such small code tweaks
> > (at least for me), because we anyway kept in sync using the repository.
> > 
> > WBR, Alexander Turenko.