From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexander.turenko@tarantool.org>
Date: Mon, 8 Oct 2018 22:08:39 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Subject: Re: [PATCH 4/4] test: refactor some requirements to pass the runs
Message-ID: <20181008190839.kh6ucxw3tuozfeze@tkn_work_nb>
References: <20181003145057.68820-1-sergw@tarantool.org>
 <20181005090215.6160-1-sergw@tarantool.org>
 <20181005090215.6160-5-sergw@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20181005090215.6160-5-sergw@tarantool.org>
To: Sergei Voronezhskii <sergw@tarantool.org>
Cc: tarantool-patches@freelists.org, Vladimir Davydov <vdavydov.dev@gmail.com>
List-ID: <tarantool-patches.dev.tarantool.org>

> test: refactor some requirements to pass the runs

requirements -> requires

'I did some stuff and things becomes cool' -- this is how I read the
commit message. What is the problem? Where it was introduced?..

WBR, Alexander Turenko.

On Fri, Oct 05, 2018 at 12:02:15PM +0300, Sergei Voronezhskii wrote:
> Part of #2436, #3232
> ---
>  test/replication/catch.result        | 3 +++
>  test/replication/catch.test.lua      | 2 +-
>  test/replication/gc.result           | 6 +++---
>  test/replication/gc.test.lua         | 2 +-
>  test/replication/on_replace.result   | 3 +++
>  test/replication/on_replace.test.lua | 1 +
>  6 files changed, 12 insertions(+), 5 deletions(-)
> 

> diff --git a/test/replication/catch.test.lua b/test/replication/catch.test.lua
> index 5223e3a24..22adb2868 100644
> --- a/test/replication/catch.test.lua
> +++ b/test/replication/catch.test.lua
> @@ -1,8 +1,8 @@
>  env = require('test_run')
> +fiber = require('fiber')
>  test_run = env.new()
>  engine = test_run:get_cfg('engine')
>  
> -
>  net_box = require('net.box')
>  errinj = box.error.injection
>  

'fiber' module is used only on replica and is required right before use.
Don't get what the fix actually fixes.

> diff --git a/test/replication/gc.test.lua b/test/replication/gc.test.lua
> index ec3bf6baa..b99253ee5 100644
> --- a/test/replication/gc.test.lua
> +++ b/test/replication/gc.test.lua
> @@ -1,8 +1,8 @@
> -fio = require 'fio'
>  test_run = require('test_run').new()
>  engine = test_run:get_cfg('engine')
>  replica_set = require('fast_replica')
>  fiber = require('fiber')
> +fio = require('fio')
>  
>  test_run:cleanup_cluster()
>  

Are this really has any effect?

> diff --git a/test/replication/on_replace.test.lua b/test/replication/on_replace.test.lua
> index 23a3313b5..e34832103 100644
> --- a/test/replication/on_replace.test.lua
> +++ b/test/replication/on_replace.test.lua
> @@ -26,6 +26,7 @@ session_type
>  test_run:cmd("switch default")
>  box.space.test:insert{2}
>  test_run:cmd("switch replica")
> +fiber = require('fiber')
>  while box.space.test:count() < 2 do fiber.sleep(0.01) end
>  --
>  -- applier
> -- 
> 2.18.0
> 

This one looks okay, but I want to see some kind of description of the
problem cause.