From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexander.turenko@tarantool.org>
Date: Mon, 8 Oct 2018 22:02:23 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Subject: Re: [PATCH 1/4] test: cleanup replication tests, parallel mode on
Message-ID: <20181008190223.fpnpzchrtna7xsgj@tkn_work_nb>
References: <20181003145057.68820-1-sergw@tarantool.org>
 <20181005090215.6160-1-sergw@tarantool.org>
 <20181005090215.6160-2-sergw@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20181005090215.6160-2-sergw@tarantool.org>
To: Sergei Voronezhskii <sergw@tarantool.org>
Cc: tarantool-patches@freelists.org, Vladimir Davydov <vdavydov.dev@gmail.com>
List-ID: <tarantool-patches.dev.tarantool.org>

On Fri, Oct 05, 2018 at 12:02:12PM +0300, Sergei Voronezhskii wrote:
> - at the end of tests which create any replication config need to call
> `test_run:clenup_cluster()` which clears `box.space._cluster`
> - switch on `use_unix_sockets` because of 'Address already in use'
> problems
> - test `once` need to clean `once*` schemas
> 
> Part of #2436, #3232
> ---

> diff --git a/test/replication/misc.test.lua b/test/replication/misc.test.lua
> index 46726b7f4..375c8b58a 100644
> --- a/test/replication/misc.test.lua
> +++ b/test/replication/misc.test.lua
> @@ -32,6 +32,8 @@ test_run:cmd(string.format('start server test with args="%s"', replica_uuid))
>  test_run:cmd('stop server test')
>  test_run:cmd('cleanup server test')
>  box.cfg{read_only = false}
> +test_run:cmd('delete server test')

delete server is not described in the commit message. BTW, should we
always do delete server after the last stop+cleanup? Or how the rule
should look?

> @@ -99,9 +102,9 @@ old_fno = lim.rlim_cur
>  lim.rlim_cur = 64
>  rlimit.setrlimit(rlimit.RLIMIT_NOFILE, lim)
>  
> -test_run:cmd('create server sock with rpl_master=default, script="replication/replica.lua"')
> -test_run:cmd(string.format('start server sock'))
> -test_run:cmd('switch sock')
> +test_run:cmd('create server bork with rpl_master=default, script="replication/replica.lua"')
> +test_run:cmd('start server bork')
> +test_run:cmd('switch bork')

Why sock -> bork? Don't find anything with the same name within
replication suite. 'Sock' means socket, but what 'bork' means? I think
it is redundant diff.

> diff --git a/test/replication/quorum.test.lua b/test/replication/quorum.test.lua
> index 5a43275c2..24d1b27c4 100644
> --- a/test/replication/quorum.test.lua
> +++ b/test/replication/quorum.test.lua
> @@ -166,7 +166,8 @@ test_run:cmd('switch replica_quorum')
>  box.cfg{replication={INSTANCE_URI, nonexistent_uri(1)}}
>  box.info.id
>  test_run:cmd('switch default')
> -test_run:cmd('stop server replica_quorum')
> -test_run:cmd('cleanup server replica_quorum')
> -test_run:cmd('delete server replica_quorum')
> +test_run:cmd("stop server replica_quorum")
> +test_run:cmd("cleanup server replica_quorum")
> +test_run:cmd("delete server replica_quorum")

Redundant diff.

> +test_run:cleanup_cluster()
>  box.schema.user.revoke('guest', 'replication')

> diff --git a/test/replication/suite.ini b/test/replication/suite.ini
> index f4abc7af1..5cbc371c2 100644
> --- a/test/replication/suite.ini
> +++ b/test/replication/suite.ini
> @@ -6,5 +6,6 @@ disabled = consistent.test.lua
>  release_disabled = catch.test.lua errinj.test.lua gc.test.lua before_replace.test.lua quorum.test.lua recover_missing_xlog.test.lua sync.test.lua
>  config = suite.cfg
>  lua_libs = lua/fast_replica.lua lua/rlimit.lua
> +use_unix_sockets = True
>  long_run = prune.test.lua
> -is_parallel = False
> +is_parallel = True

I think it should be enabled after the all fixes, in the end of the
patchset.