From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 821AE273C7 for ; Fri, 5 Oct 2018 03:15:56 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kUQknhQQH3cq for ; Fri, 5 Oct 2018 03:15:56 -0400 (EDT) Received: from smtp32.i.mail.ru (smtp32.i.mail.ru [94.100.177.92]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id C418A272D9 for ; Fri, 5 Oct 2018 03:15:55 -0400 (EDT) Date: Fri, 5 Oct 2018 10:15:47 +0300 From: Kirill Yukhin Subject: [tarantool-patches] Re: [PATCH 0/3] Delete foreign_keys and ignore_check_constraints pragmas Message-ID: <20181005071547.ue5nnjmmsgzkaeyi@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: korablev@tarantool.org Hello, On 02 Oct 13:48, AKhatskevich wrote: > Issue: https://github.com/tarantool/tarantool/issues/3696 > Branch: https://github.com/tarantool/tarantool/tree/kh/gh-3696-delete-pragmas-2 > > Those pragmas let a user turn off constraint checks. > They are considered useless and dangerous. > > AKhatskevich (3): > sql: delete unused code > sql: delete foreign_keys pragma > sql: delete ignore_check_constraints pragma > > src/box/sql.c | 3 +- > src/box/sql/CMakeLists.txt | 1 - > src/box/sql/fkey.c | 21 +-- > src/box/sql/insert.c | 7 +- > src/box/sql/main.c | 291 ------------------------------ > src/box/sql/pragma.h | 14 -- > src/box/sql/sqliteInt.h | 19 +- > test/sql-tap/check.test.lua | 15 +- > test/sql-tap/tkt-b1d3a2e531.test.lua | 8 +- > test/sql-tap/triggerC.test.lua | 5 +- > test/sql/transitive-transactions.result | 3 - > test/sql/transitive-transactions.test.lua | 1 - > 12 files changed, 12 insertions(+), 376 deletions(-) I've checked the patchset of 3 commits into 2.0 branch. Your branch contained extra commit, which didn't pass review so far. I've kicked it. (I didn't delete the branch because of that) -- Regards, Kirill Yukhin > > -- > 2.14.1 > >