From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 6B7892C3B2
	for <tarantool-patches@freelists.org>; Fri,  5 Oct 2018 00:42:30 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id MtGDgk2-62o1 for <tarantool-patches@freelists.org>;
	Fri,  5 Oct 2018 00:42:30 -0400 (EDT)
Received: from smtp46.i.mail.ru (smtp46.i.mail.ru [94.100.177.106])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 253972C3AB
	for <tarantool-patches@freelists.org>; Fri,  5 Oct 2018 00:42:30 -0400 (EDT)
Date: Fri, 5 Oct 2018 07:42:27 +0300
From: Kirill Yukhin <kyukhin@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH] sql: initialize variable containing opcode
Message-ID: <20181005044227.nvefqh6mf7gk6wmr@tarantool.org>
References: <20181004211758.12107-1-korablev@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20181004211758.12107-1-korablev@tarantool.org>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: Nikita Pettik <korablev@tarantool.org>
Cc: tarantool-patches@freelists.org

Hello,
On 05 окт 00:17, Nikita Pettik wrote:
> This bug appeared after patch on eliminating cursor usage for write
> operations in SQL (commit: 6fc3efec7). Lack of this initialization led
> to missed generation of cursor opening and as a consequence - usage of
> broken cursor during VDBE execution.
> 
> Closes #3719
> ---
> https://github.com/tarantool/tarantool/tree/np/gh-3719-fix-uninitialized-var
> https://github.com/tarantool/tarantool/issues/3719
I didn't mention your mail and prepared & committed very same change.
Here: https://www.freelists.org/post/tarantool-patches/PATCH-sql-refactor-SQL-cursor-to-remove-write-ones,8

--
Regards, Kirill Yukhin