From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 5 Oct 2018 01:00:53 +0300 From: Konstantin Osipov Subject: Re: [PATCH 09/13] gc: cleanup garbage collection procedure Message-ID: <20181004220053.GI22855@chai> References: <554ab508361da2d4015c56712f7406182019f89a.1538671546.git.vdavydov.dev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <554ab508361da2d4015c56712f7406182019f89a.1538671546.git.vdavydov.dev@gmail.com> To: Vladimir Davydov Cc: tarantool-patches@freelists.org List-ID: * Vladimir Davydov [18/10/05 00:11]: > Do some refactoring intended to make the code of gc_run() easier for > understanding: > - Remove gc_state::checkpoint_vclock. It was used to avoid rerunning > engine gc callback in case no checkpoint was deleted. Since we > maintain a list of all available checkpoints, we don't need it for > this anymore - we can run gc only if a checkpoint was actually > removed from the list. > - Rename gc_state::wal_vclock back to gc_state::vclock. > - Use bool variables with descriptive names instead of comparing > vclock signatures. > - Add some comments. OK to push. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov