From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 3 Oct 2018 11:49:34 +0300 From: Vladimir Davydov Subject: Re: [tarantool-patches] [PATCH v2] iproto: introduce a proxy module. Message-ID: <20181003084934.feltmbz76ddr7v55@esperanza> References: <20181002180554.1142-1-sergepetrenko@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181002180554.1142-1-sergepetrenko@tarantool.org> To: Serge Petrenko Cc: tarantool-patches@freelists.org List-ID: On Tue, Oct 02, 2018 at 09:05:54PM +0300, Serge Petrenko wrote: > --- > Sorry, forgot to attach issue and branch in the last letter: > https://github.com/tarantool/tarantool/issues/2625 > https://github.com/tarantool/tarantool/tree/sp/gh-2625-proxy Please don't send v2 in case the patch doesn't change at all or changes are negligible. Instead reply to the original email. > > src/box/box.cc | 68 +++- > src/box/box.h | 13 +- > src/box/errcode.h | 2 +- > src/box/iproto.cc | 708 +++++++++++++++++++++++++++++++++++++++- > src/box/iproto.h | 23 ++ > src/box/lua/cfg.cc | 2 +- > src/box/lua/net_box.c | 59 ++++ > src/box/lua/net_box.lua | 2 + > src/box/xrow.c | 46 +++ > src/box/xrow.h | 44 +++ > src/box/xrow_io.cc | 17 + > src/box/xrow_io.h | 6 + > src/scramble.c | 23 ++ > src/scramble.h | 9 + > 14 files changed, 999 insertions(+), 23 deletions(-) I haven't looked through the patch yet, but I can see from the diff that a test is missing. Please add.