From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id D9AD229DBD
	for <tarantool-patches@freelists.org>; Tue,  2 Oct 2018 03:17:59 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id zlIXp1AxU0nn for <tarantool-patches@freelists.org>;
	Tue,  2 Oct 2018 03:17:59 -0400 (EDT)
Received: from smtp46.i.mail.ru (smtp46.i.mail.ru [94.100.177.106])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 189A829DB2
	for <tarantool-patches@freelists.org>; Tue,  2 Oct 2018 03:17:59 -0400 (EDT)
Date: Tue, 2 Oct 2018 10:17:55 +0300
From: Kirill Yukhin <kyukhin@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH] sql: disallow specifying ID in <DEFAULT> clause
Message-ID: <20181002071755.cgatimb2baggjbsi@tarantool.org>
References: <20180919162027.41595-1-korablev@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20180919162027.41595-1-korablev@tarantool.org>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: Nikita Pettik <korablev@tarantool.org>
Cc: tarantool-patches@freelists.org

Hello,
On 19 сен 19:20, Nikita Pettik wrote:
> Each column may feature default value, but this value must be constant.
> Before this patch, it was allowed to do things like:
> 
> CREATE TABLE te14 (s1 INT PRIMARY KEY, s2 INT DEFAULT s1);
> 
> Which results in assertion fault on insertion. Lets prohibit IDs
> (i.e. columns' names) in <DEFAULT> clause.
> 
> Closes #3695
> ---
> Branch: https://github.com/tarantool/tarantool/tree/np/gh-3695-disallow-ID-be-default
> Issue: https://github.com/tarantool/tarantool/issues/3695
The patch is OK. I've checked it into 2.0 branch.

--
Regards, Kirill Yukhin