From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id E9BD62C6AF for ; Sat, 29 Sep 2018 01:02:34 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VuunhXv1r7-T for ; Sat, 29 Sep 2018 01:02:34 -0400 (EDT) Received: from smtp49.i.mail.ru (smtp49.i.mail.ru [94.100.177.109]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id A69432C559 for ; Sat, 29 Sep 2018 01:02:34 -0400 (EDT) Received: by smtp49.i.mail.ru with esmtpa (envelope-from ) id 1g67Oi-0001zj-JZ for tarantool-patches@freelists.org; Sat, 29 Sep 2018 08:02:33 +0300 Date: Sat, 29 Sep 2018 08:02:29 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH v2 04/11] vinyl: move transaction size sanity check to quota Message-ID: <20180929050229.GH32712@chai> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org * Vladimir Davydov [18/09/28 21:00]: > There's a sanity check in vinyl_engine_prepare, which checks if the > transaction size is less than the configured limit and fails without > waiting for quota if it isn't. Let's move this check to vy_quota_use, > because it's really a business of the quota object. This implies that > vy_quota_use has to set diag to differentiate this error from timeout. OK to push. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov