From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 2276A2C6B0 for ; Sat, 29 Sep 2018 01:00:51 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2yPkC-OU-KHb for ; Sat, 29 Sep 2018 01:00:51 -0400 (EDT) Received: from smtp61.i.mail.ru (smtp61.i.mail.ru [217.69.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id D78B62AF5B for ; Sat, 29 Sep 2018 01:00:50 -0400 (EDT) Received: by smtp61.i.mail.ru with esmtpa (envelope-from ) id 1g67N2-0006UI-Oe for tarantool-patches@freelists.org; Sat, 29 Sep 2018 08:00:49 +0300 Date: Sat, 29 Sep 2018 08:00:46 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH v2 02/11] vinyl: factor load regulator out of quota Message-ID: <20180929050046.GF32712@chai> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org * Vladimir Davydov [18/09/28 21:00]: > Turned out that throttling isn't going to be as simple as maintaining > the write rate below the estimated dump bandwidth, because we also need > to take into account whether compaction keeps up with dumps. Tracking > compaction progress isn't a trivial task and mixing it in a module > responsible for resource limiting, which vy_quota is, doesn't seem to be > a good idea. Let's factor out the related code into a separate module > and call it vy_regulator. Currently, the new module only keeps track of > the write rate and the dump bandwidth and sets the memory watermark > accordingly, but soon we will extend it to configure throttling as well. > > Since write rate and dump bandwidth are now a part of the regulator > subsystem, this patch renames 'quota' entry of box.stat.vinyl() to > 'regulator'. It also removes 'quota.usage' and 'quota.limit' altogether, > because memory usage is reported under 'memory.level0' while the limit > can be read from box.cfg.vinyl_memory, and renames 'use_rate' to > 'write_rate', because the latter seems to be a more appropriate name. > > Needed for #1862 It's all good except the name. The name is a bit more academic, generic and long than we both prefer. Other names to consider: vy_pressure_valve, vy_back_pressure, or simply vy_valve, vy_load_valve, vy_load_control, vy_rate_control, vy_bandwidth, (I think if we add more names to the table we will be able to find a good one). -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov