From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id E7F522C732 for ; Sat, 29 Sep 2018 00:27:28 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cutHPPxoNYXB for ; Sat, 29 Sep 2018 00:27:28 -0400 (EDT) Received: from smtp5.mail.ru (smtp5.mail.ru [94.100.179.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id E0FB72C730 for ; Sat, 29 Sep 2018 00:27:27 -0400 (EDT) Date: Sat, 29 Sep 2018 07:27:20 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH v1 1/1] sql: assertion in autoincrement column Message-ID: <20180929042720.GC32712@chai> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: v.shpilevoy@tarantool.org * imeevma@tarantool.org [18/09/28 19:18]: > pOut = &aMem[pOp->p2]; > - MemSetTypeFlag(pOut, MEM_Int); > + /* > + * Flag should be MEM_Int but in some cases it can > + * have an other value. See gh-3670. > + */ > + MemSetTypeFlag(pOut, pIn1->flags); Please make the comment more explicit. I should not have to dig into commit history and find the relevant test case to understand what's going on here. > > pOut->u.i = pIn1->u.i; > } -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov