From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id C7EE92B807 for ; Tue, 25 Sep 2018 19:24:29 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0iYo5dMGR7U8 for ; Tue, 25 Sep 2018 19:24:29 -0400 (EDT) Received: from smtp58.i.mail.ru (smtp58.i.mail.ru [217.69.128.38]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 1B6B72B77D for ; Tue, 25 Sep 2018 19:24:29 -0400 (EDT) Received: by smtp58.i.mail.ru with esmtpa (envelope-from ) id 1g4wgt-0004fS-I3 for tarantool-patches@freelists.org; Wed, 26 Sep 2018 02:24:27 +0300 Date: Wed, 26 Sep 2018 02:24:27 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH 07/11] vinyl: do not account zero dump bandwidth Message-ID: <20180925232427.GH3137@chai> References: <0f5578b940031e14c8e08234648c84103e0d78b2.1537435404.git.vdavydov.dev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0f5578b940031e14c8e08234648c84103e0d78b2.1537435404.git.vdavydov.dev@gmail.com> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org * Vladimir Davydov [18/09/20 12:39]: > Since we free memory in 16 MB blocks (see SLAB_SIZE), it may occur that > we dump almost all data stored in a block but still have to leave it be, > because it contains data of a newer generation. If the memory limit is > small (as it is typically in tests), this may result in dumping 0 bytes. > In order not to disrupt statistics and throttling transactions in vain, > let's simply ignore such results. Normally, the memory limit should be > large enough for such granularity not to affect the measurements > (hundreds of megabytes) so this problem isn't worth putting more efforts > into. OK to push, obviously, except you have no place to apply this patch since I haven't approved the set of patches it is based on. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov