From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 758672B523 for ; Tue, 25 Sep 2018 18:29:47 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9kdVotdmWox0 for ; Tue, 25 Sep 2018 18:29:47 -0400 (EDT) Received: from smtp39.i.mail.ru (smtp39.i.mail.ru [94.100.177.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 36CBD2B51E for ; Tue, 25 Sep 2018 18:29:47 -0400 (EDT) Received: by smtp39.i.mail.ru with esmtpa (envelope-from ) id 1g4vpx-0005b1-Bm for tarantool-patches@freelists.org; Wed, 26 Sep 2018 01:29:45 +0300 Date: Wed, 26 Sep 2018 01:29:44 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH 2/2] replication: don't stop syncing on configuration errors Message-ID: <20180925222944.GB3137@chai> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org * Vladimir Davydov [18/09/24 14:07]: > When replication is restarted with the same replica set configuration > (i.e. box.cfg{replication = box.cfg.replication}), there's a chance that > an old relay will be still running on the master at the time when a new > applier tries to subscribe. In this case the applier will get an error: On the flip side once this change is made a really invalid configuration (duplicate connection with the same replica id) won't lead to an immediate disconnect. But since we continue logging the error before applier_disconnect(), the user will still see: > main/152/applier/localhost:62649 I> can't join/subscribe > main/152/applier/localhost:62649 xrow.c:891 E> ER_CFG: Incorrect value for > option 'replication': duplicate connection with the same replica UUID assuming this message is still printed it's OK to push. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov