From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 6EEB42B516 for ; Tue, 25 Sep 2018 18:24:18 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IX0sq6mfNZkY for ; Tue, 25 Sep 2018 18:24:18 -0400 (EDT) Received: from smtp33.i.mail.ru (smtp33.i.mail.ru [94.100.177.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id B27D72B4DC for ; Tue, 25 Sep 2018 18:24:17 -0400 (EDT) Received: by smtp33.i.mail.ru with esmtpa (envelope-from ) id 1g4vkd-0006Rm-Ac for tarantool-patches@freelists.org; Wed, 26 Sep 2018 01:24:15 +0300 Date: Wed, 26 Sep 2018 01:24:12 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH 1/2] replication: fix recoverable error reporting Message-ID: <20180925222412.GA3137@chai> References: <64506bb0767e75223c8465b98745db55f7cb98be.1537715258.git.vdavydov.dev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <64506bb0767e75223c8465b98745db55f7cb98be.1537715258.git.vdavydov.dev@gmail.com> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org * Vladimir Davydov [18/09/24 14:07]: > First, we print "will retry every XX second" to the log after an error > message only for socket and system errors although we keep trying to > establish a replication connection after configuration errors as well. > Let's print this message for those errors too to avoid confusion. > > Second, in case we receive an error in reply to SUBSCRIBE command, we > log "can't read row" instead of "can't join/subscribe". This happens, > because we switch an applier to SYNC/FOLLOW state before receiving a > reply to SUBSCRIBE command. Fix this by updating an applier state only > after successfully subscribing. > > Third, we detect duplicate connections coming from the same replica on > the master only after sending a reply to SUBSCRIBE command, that is in > relay_subscribe rather than in box_process_subscribe. This results in > "can't read row" being printed to the replica's log even though it's > actually a SUBSCRIBE error. Fix this by moving the check where it > actually belongs. OK to push. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov