From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 6B09A2B31F for ; Fri, 21 Sep 2018 08:35:30 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6q_DMPXaz0Hu for ; Fri, 21 Sep 2018 08:35:30 -0400 (EDT) Received: from smtp54.i.mail.ru (smtp54.i.mail.ru [217.69.128.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id ACB202B21C for ; Fri, 21 Sep 2018 08:35:29 -0400 (EDT) Date: Fri, 21 Sep 2018 15:35:29 +0300 From: Alexander Turenko Subject: [tarantool-patches] Re: [PATCH v2] Fix warnings Message-ID: <20180921123529.brpmozsogtdv53p2@tkn_work_nb> References: <1524503321-23830-1-git-send-email-gleb-skiba@mail.ru> <20180426063849.7mmx4ch3esv3x2cc@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180426063849.7mmx4ch3esv3x2cc@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: Kirill Yukhin Cc: tarantool-patches@freelists.org I think we should use MAYBE_UNUSED for a function parameter and (void) for a function variable. At least it seems we now use them it that way. WBR, Alexander Turenko. On Thu, Apr 26, 2018 at 09:38:49AM +0300, Kirill Yukhin wrote: > Hello Gleb, > On 23 апр 20:08, Gleb wrote: > > Ensure -Werror -Wall set for the whole src/. > > Fix warnings which have been found with -Werror and -Wall. > > Add new build target RelWithDebInfoWError. > > Change build target on RelWithDebInfoWError in CI. > > > > Fixes #3238 > > --- > > diff --git a/src/box/space_def.c b/src/box/space_def.c > > index 22bd3ca..3f11088 100644 > > --- a/src/box/space_def.c > > +++ b/src/box/space_def.c > > @@ -130,6 +130,7 @@ space_def_dup(const struct space_def *src) > > * allocation refactoring. > > */ > > assert(expr_pos_old == expr_pos); > > + (void) expr_pos_old; > Could you pls use MAYBE_UNUSED, defined in util/trivia.h, instead? > (everywhere in your patch) > > -- > Regards, Kirill Yukhin >