From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 21 Sep 2018 12:33:14 +0300 From: Vladimir Davydov Subject: Re: [PATCH v3.1 2/5] box: introduce tuple_field_by_part routine Message-ID: <20180921093314.amihvfr3p4lmguiq@esperanza> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: To: Kirill Shcherbatov Cc: tarantool-patches@freelists.org List-ID: On Thu, Sep 20, 2018 at 10:46:50AM +0300, Kirill Shcherbatov wrote: > +const char * > +tuple_field_by_part_raw(const struct tuple_format *format, const char *data, > + const uint32_t *field_map, struct key_part *part) > +{ > + return tuple_field_raw(format, data, field_map, part->fieldno); > +} This function must be defined as inline for now so as not to introduce any slowdown to hot paths. I moved it to tuple_format.h and pushed the patch to 1.10. You'll have to move it back to tuple_format.c in the main patch of the series, which makes it more than just a wrapper.