From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id AE9AE2A534 for ; Thu, 20 Sep 2018 22:53:48 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EvvtOA2PWze9 for ; Thu, 20 Sep 2018 22:53:48 -0400 (EDT) Received: from smtp42.i.mail.ru (smtp42.i.mail.ru [94.100.177.102]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 6F7AC2A2AC for ; Thu, 20 Sep 2018 22:53:48 -0400 (EDT) Date: Fri, 21 Sep 2018 05:53:47 +0300 From: Alexander Turenko Subject: [tarantool-patches] Re: [PATCH 2/2] test: add output filtering feature Message-ID: <20180921025347.ommfgqpn7v35vi6p@tkn_work_nb> References: <1536282019-17978-1-git-send-email-roman.habibov1@yandex.ru> <41907181536625411@iva8-8d7a47df0521.qloud-c.yandex.net> <41826271536625517@iva7-bd007c44f58e.qloud-c.yandex.net> <20180919133830.bvtnqh3ftbdukobh@tkn_work_nb> <5087171537491282@myt5-f9d71769b752.qloud-c.yandex.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <5087171537491282@myt5-f9d71769b752.qloud-c.yandex.net> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: roman.habibov1@yandex.ru Cc: tarantool-patches@freelists.org, Kirill Shcherbatov Hi! Minor comments are below. WBR, Alexander Turenko. On Fri, Sep 21, 2018 at 03:54:42AM +0300, roman.habibov1@yandex.ru wrote: > > Add output filtering feature for engine/savepoint.test. > > Part of #3518. > --- > commit b8be4c51e29110f459bd58dba51d6546cd9da25b > Author: Roman Khabibov > Date: Fri Sep 21 03:28:04 2018 +0300 > > test: add output filtering feature > Please, describe the change in less abstract manner, like 'test: filter line numbers from engine/savepoint'. Now the description looks like you are implement this feature from scratch. > diff --git a/test/engine/savepoint.test.lua b/test/engine/savepoint.test.lua > index de8f297..9d4be7f 100644 > --- a/test/engine/savepoint.test.lua > +++ b/test/engine/savepoint.test.lua > @@ -1,5 +1,6 @@ > env = require('test_run') > test_run = env.new() > +test_run:cmd("push filter '(.builtin/.*).lua:346' to '\\1.lua:340'") > Tricky thing :) It is better to remove line numbers entirely as socket.test.lua does and update the result file, because the current approach does not protect us from the next line numbers change. Also I propose to place this commit before 'box: add a method to check if txn is open' to achieve two points: * each commit passes the tests (can be useful when someone will bisect some problem in the future and is generally recommended way); * don't need to update the test result twice (update line numbers, then remove line numbers).