From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 755592A907 for ; Thu, 20 Sep 2018 22:41:48 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YHTpuL49Ohyn for ; Thu, 20 Sep 2018 22:41:48 -0400 (EDT) Received: from smtp43.i.mail.ru (smtp43.i.mail.ru [94.100.177.103]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 2D635206F6 for ; Thu, 20 Sep 2018 22:41:48 -0400 (EDT) Date: Fri, 21 Sep 2018 05:41:45 +0300 From: Alexander Turenko Subject: [tarantool-patches] Re: [PATCH 1/1] box: add a method to check if transaction is open Message-ID: <20180921024144.5x5vu3qrdcdoa24v@tkn_work_nb> References: <1536282019-17978-1-git-send-email-roman.habibov1@yandex.ru> <41907181536625411@iva8-8d7a47df0521.qloud-c.yandex.net> <41826271536625517@iva7-bd007c44f58e.qloud-c.yandex.net> <20180919133830.bvtnqh3ftbdukobh@tkn_work_nb> <5119501537491277@myt3-12f13c3c6b95.qloud-c.yandex.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <5119501537491277@myt3-12f13c3c6b95.qloud-c.yandex.net> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: roman.habibov1@yandex.ru Cc: "tarantool-patches@freelists.org" , Kirill Shcherbatov This commit looks good to me, except one comment. WBR, Alexander Turenko. > +box.is_in_txn = function() > + return builtin.box_txn() > +end > + Can be reduced to just `box.is_in_txn = builtin.box_txn`.